Improvements to filesystem abstractions (part 3)

[arturcic]

This pull request includes several changes to improve the test infrastructure and refactor the code for better maintainability. The most important changes involve adding new dependencies, refactoring the service configuration, and replacing various helper methods with a unified FileSystemHelper class.

Dependency Management:

• Added System.IO.Abstractions package reference in GitVersion.Common.csproj to facilitate file system abstractions.

Refactoring Service Configuration:

• Refactored SetUp methods in ArgumentParserOnBuildServerTests and ArgumentParserTests to use GitVersionAppModule for service configuration. [1] [2]

File System Helper Integration:

• Replaced PathHelper and DirectoryHelper methods with FileSystemHelper methods across multiple test files for consistency and improved readability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

Code Cleanup:

• Removed unused PathHelper and DirectoryHelper methods and replaced them with FileSystemHelper in various test assertions and setups. [1] [2] [3] [4] [5]

Additional Imports:

• Added necessary imports for GitVersion.Extensions and GitVersion.FileSystemGlobbing in relevant files to support the new changes. [1] [2] [3]

[Copilot]

Copilot reviewed 75 out of 76 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

• new-cli/GitVersion.Common/GitVersion.Common.csproj: Language not supported

Comments suppressed due to low confidence (1)

src/GitVersion.App.Tests/ExecCmdLineArgumentTest.cs:55

• [nitpick] Verify that using GetTempPathLegacy is intentional; if legacy behavior is not required, standardizing on FileSystemHelper.Path.GetTempPath may improve consistency.

        var workingDirectory = FileSystemHelper.Path.GetTempPathLegacy();

[Copilot]

Pull Request Overview

This PR refactors filesystem operations to use a unified FileSystemHelper for better maintainability and improved test infrastructure while also updating dependency management and service configuration.

• Replaces all usages of PathHelper and DirectoryHelper with FileSystemHelper calls.
• Refactors service configuration to use GitVersionAppModule for dependency injection.
• Updates various test files to align with the new filesystem abstraction patterns.

Reviewed Changes

Copilot reviewed 75 out of 76 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/GitVersion.App/GitVersionExecutor.cs	Uses FileSystemHelper for mutex naming and error messages replacing PathHelper calls.
src/GitVersion.App/GitVersionAppModule.cs	Adds necessary import for GitVersion.FileSystemGlobbing.
src/GitVersion.App/FileSystemGlobbing/MatcherExtensions.cs	Implements globbing extensions using IFileSystem with modern syntax.
src/GitVersion.App/FileSystemGlobbing/IGlobbingResolver.cs	Updates namespace to GitVersion.FileSystemGlobbing.
src/GitVersion.App/FileSystemGlobbing/GlobbingResolver.cs	Uses new constructor syntax with IFileSystem and integrates with FileSystemHelper usage.
src/GitVersion.App/FileSystemGlobbing/FileSystemInfoGlobbingWrapper.cs	Wraps IFileSystemInfo to support file system globbing.
src/GitVersion.App/FileSystemGlobbing/FileInfoGlobbingWrapper.cs	Wraps IFileInfo correctly with FileSystemHelper integration.
src/GitVersion.App/FileSystemGlobbing/DirectoryInfoGlobbingWrapper.cs	Implements directory info abstraction using IFileSystem with a minor potential inconsistency.
src/GitVersion.App/FileAppender.cs	Replaces PathHelper with FileSystemHelper for log file operations.
src/GitVersion.App/ArgumentParserExtensions.cs	Consistently utilizes FileSystemHelper for path operations.
src/GitVersion.App/ArgumentParser.cs	Updates configuration file and argument parsing to use FileSystemHelper.
Test Files (e.g., UpdateWixVersionFileTests.cs, TagCheckoutInBuildAgentTests.cs, PullRequestInBuildAgentTest.cs, etc.)	Replace legacy helper calls with FileSystemHelper to ensure consistent filesystem access.
src/GitVersion.App.Tests/Helpers/GitVersionHelper.cs	Updates log file operations and current directory retrieval using FileSystemHelper.
src/GitVersion.App.Tests/ExecCmdLineArgumentTest.cs	Updates temporary path retrieval to use the new FileSystemHelper API.
src/GitVersion.App.Tests/ArgumentParserTests.cs	Ensures test assertions reference FileSystemHelper for consistent filename and path handling.
src/GitVersion.App.Tests/ArgumentParserOnBuildServerTests.cs	Updates service registration to use GitVersionAppModule.

Files not reviewed (1)

• new-cli/GitVersion.Common/GitVersion.Common.csproj: Language not supported

[Copilot]

Copilot reviewed 75 out of 76 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

• new-cli/GitVersion.Common/GitVersion.Common.csproj: Language not supported

[Copilot]

Copilot reviewed 75 out of 76 changed files in this pull request and generated no comments.

Files not reviewed (1)

• new-cli/GitVersion.Common/GitVersion.Common.csproj: Language not supported

[mergify]

Thank you @arturcic for your contribution!

[gittools-bot]

🎉 This issue has been resolved in version 6.3.0 🎉
The release is available on:

• GitHub Release
• Chocolatey Package
• .Net Global Tool

Your GitReleaseManager bot 📦🚀