Introduce Qodana analysis

[arturcic]

This pull request includes significant updates to .editorconfig rules, introduces a new Qodana code quality workflow and configuration, and refactors various test files and the ArgumentParser class to improve code clarity and maintainability. Below is a summary of the most important changes:

Code Style and Analyzer Rule Updates:

• Updated .editorconfig to adjust severity levels for various C# style rules, such as changing csharp_style_var_* rules from silent to suggestion. Removed several IDE and CA diagnostic rules, such as IDE0011 (add braces) and CA1825 (avoid zero-length array allocations). [1] [2]
• Added ReSharper-specific rules, including resharper_csharp_use_roslyn_logic_for_evident_types and resharper_csharp_instance_members_qualify_members. [1] [2]

Qodana Code Quality Workflow:

• Introduced a new Qodana code quality workflow in .github/workflows/qodana_code_quality.yml to integrate JetBrains Qodana into CI/CD pipelines. This includes branch-specific triggers and steps for setup and scanning.
• Added a qodana.yaml configuration file to define inspection profiles and rules for Qodana analysis, enabling and excluding specific inspections.
• Updated build/CI.slnx to include the qodana.yaml file and the new Qodana workflow. [1] [2]

Test Refactoring:

• Updated test files to improve readability and consistency, such as replacing string concatenation with raw string literals and simplifying variable declarations. Examples include changes in ArgumentParserTests.cs, ExecCmdLineArgumentTest.cs, and VersionWriterTests.cs. [1] [2] [3]
• Refactored test helper methods, such as modifying Run in ProgramFixture.cs to remove unnecessary array conversion.

ArgumentParser Improvements:

• Simplified logic in ArgumentParser.cs by reducing unnecessary nesting and improving readability, such as combining single-line if statements and removing redundant code. [1] [2]
• Improved error messages for invalid arguments, such as using string interpolation for better clarity.

Miscellaneous Changes:

• Updated ExecutionResults in Helpers/ExecutionResults.cs to remove init accessors for properties that are initialized in the constructor.
• Fixed a test assertion in UpdateWixVersionFileTests.cs to use Count instead of Count().

[Copilot]

Pull Request Overview

This PR introduces Qodana analysis and various code quality improvements, alongside refactoring tests and the ArgumentParser to enhance clarity and maintainability. Key updates include:

• Adjustments to editorconfig and analyzer rules, and the addition of ReSharper-specific configurations.
• Integration of a new Qodana CI/CD workflow and configuration file.
• Refactoring of test files and improvements in ArgumentParser logic.

Reviewed Changes

Copilot reviewed 234 out of 236 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/GitVersion.BuildAgents/Agents/EnvRun.cs	Changed environment variable constant to private and streamlined condition checks.
src/GitVersion.BuildAgents/Agents/Drone.cs	Reversed conditional logic for branch detection and standardized environment variable retrieval.
src/GitVersion.BuildAgents/Agents/BitBucketPipelines.cs	Simplified string output and inline conditional logic for branch identification.
src/GitVersion.BuildAgents/Agents/AzurePipelines.cs	Streamlined conditionals using ternary operators for branch/tag handling and build number updates.
src/GitVersion.BuildAgents/Agents/AppVeyor.cs	Optimized branch retrieval using a ternary operator with environment variables.
src/GitVersion.App/QuotedStringHelpers.cs	Adopted new C# raw array literal syntax for filtering split strings.
src/GitVersion.App/OverrideConfigurationOptionParser.cs	Minor type declaration changes for improved consistency.
src/GitVersion.App/FileSystemGlobbing/DirectoryInfoGlobbingWrapper.cs	Refactored file system enumeration and exception messaging.
src/GitVersion.App/ArgumentParser.cs	Simplified target path parsing and switch handling logic.
src/GitVersion.App.Tests/*	Various test refactorings including string literal updates and type adjustments.
qodana.yaml	New Qodana configuration file defining inspection profiles and rules.
.github/workflows/qodana_code_quality.yml	New GitHub workflow for running Qodana analysis on specified branches.

Files not reviewed (2)

• .editorconfig: Language not supported
• build/CI.slnx: Language not supported

[mergify]

Thank you @arturcic for your contribution!

[gittools-bot]

🎉 This issue has been resolved in version 6.3.0 🎉
The release is available on:

• GitHub Release
• Chocolatey Package
• .Net Global Tool

Your GitReleaseManager bot 📦🚀