refactors qodana profile and enables checks #4517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to dependencies, refactors for improved code maintainability, enhancements to Qodana configuration, and namespace adjustments to improve project organization.
Dependency Updates:
v2025.1.0
in.github/workflows/qodana_analysis.yml
.Refactoring and Code Simplification:
WorkingDirectory
property from theIConverterContext
interface and its implementations, simplifying theOutputContext
record structure [1] [2] [3].VersionVariableSerializer
to makeFromJson
a static method, improving usability and clarity.IIgnoreConfiguration.IsEmpty
[1] [2].Qodana Configuration Enhancements:
.github/workflows/qodana_code_quality.yml
to.github/workflows/qodana_analysis.yml
and updated references inbuild/CI.slnx
.qodana.yaml
, including renaming and reorganizing inspection names for better clarity and adding specific file exclusions for certain inspections [1] [2] [3].Namespace Adjustments:
ExecutableHelper
fromGitVersion.Core.Tests.Helpers
toGitVersion.App.Tests.Helpers
to align with its usage context and updated references accordingly [1] [2] [3] [4].Minor Test and Code Improvements:
IEnvironment
withTestEnvironment
in various test files for consistency and better test isolation [1] [2] [3].