Restore borders on embed blocks with Captions #2755
Conversation
Fixes oversight in commit 994eb, the border in Caption should be removed when the Caption wraps image blocks, but embed blocks should be bordered
|
| return ( | ||
| <Caption {...props} wrapperStyle={[]}> | ||
| <Caption {...props}> | ||
| <Link | ||
| href={file.downloadURL} | ||
| download={file.name} |
There was a problem hiding this comment.
@SamyPesse I removed the styles and empty wrapperStyle that was passed to Caption in the Files block. As also mentioned in the PR description: "improves consistency by having the Files block adhere to the same bordering styles from Caption, it was using its own but these were a bit different"
Let me know if you added explicitly different bordering styles on the Files block on purpose, but if not, I think its nice to streamline these styles while i'm at it.
|
GitBook Preview |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
viktorrenkema
force-pushed
the
viktor/fix-border-styling-links
branch
from
2dad85f to
cd4d835
Compare
viktorrenkema
force-pushed
the
viktor/fix-border-styling-links
branch
from
cd4d835 to
b5f5463
Compare
Fixes oversight in commit 994eb.
The Caption block wraps a couple other blocks to enable captions. In a prior PR the border on the Caption block was removed as we wanted it removed on images and drawings, as these can function as diagrams with white backgrounds, and a border adds more noise than utility then.
However, this also removed the border on the Embed block, which is an external link block.
This PR:
Before (url embed block & files block)
After: