Skip to content

Track Insights link clicks on the file block Download button - #4632

Merged
nolannbiron merged 1 commit into
mainfrom
nolann/track-file-download-click
Sep 23, 2026
Merged

nolannbiron merged 1 commit into
mainfrom
nolann/track-file-download-click

Conversation

@nolannbiron

@nolannbiron nolannbiron commented Sep 23, 2026

Copy link
Copy Markdown
Member

Proposed changes

DownloadButton has no href, so Button renders a plain <button> and drops its insights prop. Clicks on a file block's Download button were never tracked. The button now sends the link_click event itself before starting the download. The filename link and the Open button were already tracked and don't change.

@changeset-bot

changeset-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fa34d4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@argos-ci

argos-ci Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2-cloudflare (Inspect) ✅ No changes detected 6 ignored Sep 23, 2026, 3:11 PM
customers-v2-vercel (Inspect) 👍 Approved by Nolann Biron 6 changed, 2 ignored Sep 23, 2026, 3:08 PM
v2-cloudflare (Inspect) 👍 Approved by Nolann Biron 2 changed, 3 ignored Sep 23, 2026, 3:11 PM
v2-vercel (Inspect) ✅ No changes detected 3 ignored Sep 23, 2026, 3:11 PM

@github-actions

Copy link
Copy Markdown
Contributor

Style invalidation on a large API reference

Elements restyled by opening one popup on the Snyk API reference. A share near or above 100% means the insertion restyles the whole document.

interaction restyled page share budget
openapi-select 6 10,802 0.1% 25%
search 639 10,802 5.9% 125%

@nolannbiron
nolannbiron enabled auto-merge (squash) September 23, 2026 15:12
@nolannbiron
nolannbiron merged commit 8dd9444 into main Sep 23, 2026
20 checks passed
@nolannbiron
nolannbiron deleted the nolann/track-file-download-click branch September 23, 2026 15:16

This branch was successfully deployed

2 active deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants