fix(query): stop repeated tool-failure loops#1219
Open
chioarub wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #1102 reports runaway loops where the model repeatedly retries failed file writes/edits or invalid fallback tool calls, burning tokens without making progress. This change adds a small circuit breaker in the query loop rather than refactoring individual tools.
This does not repair the underlying file-write failure or provider/tool-schema issue. It stops the runaway loop and gives the user a concrete diagnostic so they can inspect permissions, paths, or tool schema before retrying.
Validation
bun test src/query/toolFailureLoopGuard.test.tspassed: 22 tests.bun run buildpassed.git diff --checkpassed.bun run typecheckstill fails on existing repo-wide snapshot/type issues unrelated to this change, including missing modules/exports and pre-existingsrc/query.tsreferences outside the guard path.