fix: add store:false to Chat Completions and /responses fallback#572
Closed
Zartris wants to merge 1 commit intoGitlawb:mainfrom
Closed
fix: add store:false to Chat Completions and /responses fallback#572Zartris wants to merge 1 commit intoGitlawb:mainfrom
Zartris wants to merge 1 commit intoGitlawb:mainfrom
Conversation
Set store: false in the request body for both the Chat Completions path and the /responses fallback path in openaiShim.ts. The codexShim (Responses API primary path) already sets store: false. The Chat Completions path and the /responses fallback in openaiShim were missing it. store: false tells the API provider not to persist conversation data for model training, logging, or other non-operational purposes. This is a privacy measure — it does not affect caching or functionality. Note: Whether third-party proxies (e.g. GitHub Copilot) honour this parameter is provider-dependent, but setting it is a reasonable default for user privacy.
Contributor
Author
|
Reopening with pr/ branch naming convention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
store: falseto the Chat Completions and/responsesfallback request bodies inopenaiShim.ts.Problem
The Responses API primary path (
codexShim.ts) already setsstore: false, but the Chat Completions path and the/responsesfallback inopenaiShim.tsdo not. This creates an inconsistency where some API paths opt out of server-side data storage and others do not.Changes
store: falseto the Chat Completions request body (line ~1161)store: falseto the/responsesfallback request body (line ~1336)Context
store: falsetells the API provider not to persist conversation data for model training, logging, or other non-operational purposes. This is a privacy measure that does not affect caching or functionality.Whether third-party proxies (e.g. GitHub Copilot) honour this parameter is provider-dependent, but setting it is a reasonable default for user privacy and consistency with the codexShim path.