fix: WebSearch providers + MCPTool bugs#590
Closed
FluxLuFFy wants to merge 2 commits into
Closed
Conversation
WebSearchTool: - custom.ts: fix buildAuthHeadersForPreset WEB_AUTH_HEADER opt-out - custom.ts: fix WEB_AUTH_SCHEME empty string handling - custom.ts: fix walkJsonPath null safety for jsonPath parsing - duckduckgo.ts: use SafeSearchType enum instead of raw 0 - mojeek.ts: always send Accept: application/json header - README: fix timeout documentation (15s -> 120s to match code) - custom.test.ts: add tests for auth header behavior MCPTool: - MCPTool.ts: fix outputSchema to accept ContentBlockParam[] (not just string) - MCPTool.ts: fix isResultTruncated for array output (iterates text blocks)
Contributor
Author
- Add native Gemini shim (geminiShim.ts) using @google/generative-ai SDK directly instead of OpenAI-compatible endpoint. Fixes thought_signature 400 errors since the native SDK handles function calling natively. - Rename CLAUDE_CODE_USE_GEMINI → CLAUDE_CODE_GOOGLE across all files. - Fix thought_signature sentinel in openaiShim.ts — replace rejected 'skip_thought_signature_validator' with deterministic pseudo-signature from tool call ID for OpenAI-compatible fallback path. - Update StartupScreen: show 'Google (compatible)' provider label, add Search line showing active search provider (firecrawl, tavily, ddg, etc.) - Update tests for native Gemini routing. All 682 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebSearch Providers
MCPTool