workflows: accept underscore modules in PR titles - #26
Merged
Conversation
Consumer repositories use snake_case board and module identifiers in stable PR title prefixes, but the shared readiness regex rejected those valid owners. - Allow underscores after the first lowercase letter in each prefix segment - Cover the Zero ESP regression and preserve malformed-title rejection - Document the exact prefix character contract for consumers Generated with [Codex](https://github.com/openai)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ OpenAI PR Review: PASS
Conclusion: Ready from the OpenAI review perspective. PR format, linked Issue design, and code/plan conformance passed with no actionable findings.
Review checks
| Check | Result |
|---|---|
| PR format | ✅ PASS |
| Issue design | ✅ PASS |
| Code & plan conformance | ✅ PASS |
Scope: 4c6af5ed09 · cff6ec446b..4c6af5ed09 · full · 1 diff chunk
Usage: 43s · 298,047 tokens · 79.4% cache hit · 6.431 credits
Summary
All completed chunk reviews are consistent with the linked Issue plan. No actionable code findings or plan-conformance blockers remain.
Review metadata
- Commit:
4c6af5ed09 - Range:
cff6ec446b..4c6af5ed09 - Mode:
full - Diff chunks:
1 - Model:
gpt-5.6-terra - Reasoning effort:
medium - Session:
repo-1309321116-pr-26-v2 - Generation:
25d7ffefdb669f4a09a04693acfa2257d687b63761ff33fced7bdcc26a79b5df - Evidence:
895b495775893edf2b7929463f03bfd1d11d9fcc78c4beabcb063205a877d7f3
Totals
- Input:
294,911 - Cached input:
234,261 - Cache write:
60,611 - Output:
3,136 - Reasoning:
1,366 - Total:
298,047 - Estimated credits:
6.431 - Credit rate per 1M tokens:
62.5input /6.25cached /375output
Token and cache details
| Stage | Mode | Target | Time | Input | Cached | Hit | Output | Total | Credits |
|---|---|---|---|---|---|---|---|---|---|
pr |
deterministic |
format rules |
0s | 0 | 0 | 0.0% | 0 | 0 | 0.000 |
pr |
full |
pr |
5s | 19,129 | 9,271 | 48.5% | 273 | 19,402 | 0.776 |
issue |
full |
Issue #25 |
16s | 90,199 | 72,706 | 80.6% | 1,405 | 91,604 | 2.075 |
code |
full |
chunk 1/1 |
18s | 120,346 | 89,156 | 74.1% | 1,265 | 121,611 | 2.981 |
code |
full |
aggregate |
4s | 65,237 | 63,128 | 96.8% | 193 | 65,430 | 0.599 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25
Summary
h106/zero_espas a valid consumer module while retaining malformed-title rejectionValidation
node .github/scripts/issue-review/test.mjsnode .github/scripts/pr-readiness/test.mjsnode .github/scripts/pr-review/test.mjsgit diff --check