Fix macOS build error: remove juce::Graphics::getCurrentColour() call - #12
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/GizzZmo/DSP4Guitar/sessions/fd6b125f-c2fd-4889-b2c6-e0df6c80d1ec Co-authored-by: GizzZmo <8039975+GizzZmo@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
GizzZmo
April 25, 2026 17:34
View session
GizzZmo
marked this pull request as ready for review
April 25, 2026 17:34
There was a problem hiding this comment.
Pull request overview
Removes usage of the non-existent juce::Graphics::getCurrentColour() API (JUCE 7.0.9) by computing the intended text colour locally before setting it, resolving a macOS compile error.
Changes:
- Replace
getCurrentColour().brighter(...)with a localtextColourvariable that is optionally brightened. - Consolidate text colour selection into a single
g.setColour(...)call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+196
to
+197
| textColour = textColour.brighter (0.2f); | ||
| g.setColour (textColour); |
There was a problem hiding this comment.
Spacing around parentheses is inconsistent with the surrounding method calls in this file (e.g., g.setColour(matrixGreen) / textColour.brighter(…)). Consider removing the extra spaces in textColour.brighter (0.2f) and g.setColour (textColour) to match the local style and reduce diff noise.
Suggested change
| textColour = textColour.brighter (0.2f); | |
| g.setColour (textColour); | |
| textColour = textColour.brighter(0.2f); | |
| g.setColour(textColour); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
juce::Graphicsdoes not exposegetCurrentColour()in JUCE 7.0.9, causing a hard compile error on macOS. Replace the two-step colour lookup with an explicit local variable computed from the same source values.Before:
After:
Behavior is identical; only the non-existent API call is removed.
Type of Change
Testing
Checklist
Screenshots (if applicable)