feat: improve usability — double-click reset, chain-order badges, tooltips; update SVG screenshot - #15
Merged
Conversation
…ltips; update SVG screenshot Agent-Logs-Url: https://github.com/GizzZmo/DSP4Guitar/sessions/9b8d1f40-820b-470a-879c-a47c47a2f127 Co-authored-by: GizzZmo <8039975+GizzZmo@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
GizzZmo
May 3, 2026 23:51
View session
GizzZmo
marked this pull request as ready for review
May 3, 2026 23:51
There was a problem hiding this comment.
Pull request overview
This PR updates the JUCE plugin editor UI to improve usability (knob reset behavior, richer tooltips, and chain-order badges) and refreshes the UI screenshot SVG to match the current 4-row layout.
Changes:
- Add double-click reset on rotary sliders using each parameter’s default value derived from its
NormalisableRange. - Add hover tooltips via a
juce::TooltipWindow, populating per-slider parameter info (name, range, default, reset hint). - Add signal-chain order badges to panel headers and update the SVG screenshot asset accordingly.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
PluginEditor.cpp |
Adds slider double-click reset + tooltips; updates panel drawing calls and renders chain-order badges. |
PluginEditor.h |
Updates drawEffectPanel signature and introduces a tooltip window member. |
assets/screenshots/plugin_ui.svg |
Replaces the UI screenshot SVG to reflect the 4-row layout and new badges. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| juce::Rectangle<int> panelBounds (int col, int row) const; | ||
|
|
||
| // Tooltip window – shows parameter info on hover | ||
| juce::TooltipWindow tooltipWindow { this, 600 }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three targeted usability improvements to the plugin UI, plus an accurate replacement SVG screenshot.
Description
Double-click to reset knobs — every rotary slider now calls
setDoubleClickReturnValue(true, defaultVal), wheredefaultValis derived from the parameter'sRangedAudioParameternormalizable range. Standard DAW convention, previously absent.Hover tooltips — a
juce::TooltipWindow(600 ms) is added to the editor. Each slider receives asetTooltip()showing full parameter name, min–max range, default value, and a reset hint. Fixes the usability gap caused by abbreviated labels likeFbk,Damp,Q.Signal-chain order badges —
drawEffectPanelgains anint chainOrderparameter; a#Nbadge renders in the top-right of each panel header (cyan when active, gray when bypassed), mapping directly to the documented processing order:SVG screenshot — regenerated to match the actual
908×868four-row layout. The old screenshot was910×666(three rows, missing Fuzz panel, pre-badge).Type of Change
Testing
Checklist
Screenshots (if applicable)
Updated
assets/screenshots/plugin_ui.svgnow reflects the correct four-row layout with chain-order badges and toggle LEDs. See the regenerated file for a full visual reference.