-
Notifications
You must be signed in to change notification settings - Fork 47
Implement coregistration functionality for CLI #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great! 🙂 I don't have much to comment on the code, my main remark at this stage is rather on the structure: Should we already anticipate other CLI usage than coregistration (e.g., terrain attributes, uncertainty)? If yes, we could potentially separate into different namings, for instance by adding a first parameter to the parsing: Small remarks:
inlier_rst = coreg_dem.copy(new_array=inlier_mask)
inlier_rst.save("xxx.tif") |
8f53ba9 to
42c96dc
Compare
|
Thanks for your feedback @rhugonnet.
|
f050c91 to
45fcd54
Compare
c72d5be to
dba0af8
Compare
6602bab to
b9af0e1
Compare
|
Updated following the merge of PR #617 |
2257f39 to
8b2b856
Compare
8b2b856 to
e0b9b97
Compare
0c4313d to
3940dc1
Compare
|
@adebardo @belletva @marinebcht I assume we can close this PR now. CLI (building on top of this first implementation) was added in #764. |
Resolves #622 and #623
Description
This PR implements the coregistration functionality for the CLI. The aim is to enhance the xdem run by adding the necessary functions to verify the existence of both input paths and executing the coregistration of DEMs.
Key Changes:
Path Verification:
Loading DEMs:
geoutils.rasters.load_multiple_rastersaccessor to load the reference and secondary DEMs:Coregistration Execution:
Integrated the
dem_coregistrationfunction from theworkflowsmodule to perform the coregistration:The aligned DEM is saved as
aligned_dem.tiff, and the inlier mask is saved asinlier_mask.tiff.Output Verification:
Testing:
Developed tests to retrieve test data and validate the outputs against ground truth data as specified in
tests/test_cli.py.Documentation
Updated the Quick Start Guide in the documentation to reflect the new coregistration capabilities and usage instructions.