Change SP3012-06UTG to SC7538-08UTG as the former is EOL. #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff is quite massive and seems to include unrelated changes (something about nextpcb-bom?). I understand this is probably in part because of a KiCAD version upgrade. Could you please submit a separate PR doing nothing but updating the design files to the latest KiCAD version, from a clean checkout? |
|
Ah sorry, yes I accidentally committed the NextPCB fab files I was testing with. |
|
This PR has a merge conflict now. |
|
Naturally.. 3rd time's the charm I hope |
|
Huh, that is still a 20 kloc diff. I'm not sure when I'll get around to reviewing it in KiCAD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace 2 SP3012s with 1 SC7538 as it has 8 channels rather than 6.
Note that this does not clamp to VIO like the old circuit but hopefully that is not an issue.