fix: Major Fix on 2024 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 24, 2024 18:33
- fix implementation if user using constraint - remove public init(frame:direction:) and change to init(width:direction:) instead - fix variable declaration, dont use mandatory on optional value to prevent any crash on runtime - fix first time set pageControl position - fix crash if _carouselData is null
added 4 commits
January 25, 2024 13:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix implementation if user using constraint
remove public init(frame:direction:) and change to init(width:direction:) instead
fix variable declaration, dont use mandatory on optional value to prevent any crash on runtime
fix first time set pageControl position
fix crash if _carouselData is null
@Glianze