Fix invalid package-lock.json entries#545
Merged
Merged
Conversation
…date versions There's not an easy way to regenerate the lockfile while preserving the exact versions because the NPM issue appears to be with version resolution. This particular set of versions randomly caused the issue ¯\_(ツ)_/¯ This is caused by npm/cli#6301 and was caught by NixOS/nixpkgs#479805
Contributor
Author
Collaborator
|
Thank you @magneticflux-! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of an NPM bug,
package-lock.jsonfiles can randomly become corrupted and lack resolved URL and integrity hash fields. The normalnpm installsilently ignores the problem, but I ran into it because I am working on updating this package inNixOS/nixpkgsand the Nix builder requires all NPM dependencies to be pre-downloaded and verified by hash.The relevant issues are linked in the first commit.
After that, I moved the Babel plugin to its new name to silence a warning.
No package version specs were changed, but there were some minor updates. There's not an easy way to regenerate the lockfile while preserving the exact versions because the NPM issue appears to be with the specific versions being resolved and it fails to write these specific fields every time.