Skip to content

Modernization#95

Merged
GlobalHive merged 36 commits into
GlobalHive:masterfrom
AdamDrewsTR:modernization
Oct 10, 2025
Merged

Modernization#95
GlobalHive merged 36 commits into
GlobalHive:masterfrom
AdamDrewsTR:modernization

Conversation

@AdamDrewsTR

Copy link
Copy Markdown
Contributor

Modernize, tests, etc

@GlobalHive GlobalHive self-assigned this Oct 4, 2025
@GlobalHive GlobalHive added enhancement New feature or request WIP labels Oct 4, 2025
@GlobalHive

Copy link
Copy Markdown
Owner

Hey @AdamDrewsTR,
thank you for your huge pull request — that’s some really awesome work!
I’ll go through it, run some tests, and get back to you as soon as possible.

Best regards,
Sascha

@AdamDrewsTR

Copy link
Copy Markdown
Contributor Author

Hey @AdamDrewsTR, thank you for your huge pull request — that’s some really awesome work! I’ll go through it, run some tests, and get back to you as soon as possible.

Best regards, Sascha

Sounds good. Will you look at the Codacy warnings as well? I can't seem to suppress, ignore, resolve them. I am less familiar with that tool for static analysis.

@GlobalHive

Copy link
Copy Markdown
Owner

yes, but it will take some time.

Best Regards
Sascha

@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@AdamDrewsTR

Copy link
Copy Markdown
Contributor Author

Finally!!!

@GlobalHive

Copy link
Copy Markdown
Owner

That’s all, then? Putting it on top... Sometimes programs behave unpredictably — it’s odd.
I’ll check the functionality now to make sure nothing is broken in my local project.
If everything works as expected, we’re ready for the merge.

Release-As: 2.4.0
@GlobalHive GlobalHive merged commit f346e63 into GlobalHive:master Oct 10, 2025
6 of 7 checks passed
@GlobalHive

Copy link
Copy Markdown
Owner

Thank you very much for your excellent work.
If you have PayPal or another preferred payment method, please let me know — good work deserves to be rewarded!

Best regards,
Sascha

@AdamDrewsTR

Copy link
Copy Markdown
Contributor Author

Thank you very much for your excellent work. If you have PayPal or another preferred payment method, please let me know — good work deserves to be rewarded!

Best regards, Sascha

No worries, but thank you! With the somewhat recent license change on shepherd.js, having some solid alternatives is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request WIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants