feat: add Calico Helm values module and configuration files - #589
feat: add Calico Helm values module and configuration files#589hamzabouissi wants to merge 5 commits into
Conversation
github-actions
Bot
added
include-in-release-notes
enhancement
There was a problem hiding this comment.
Pull request overview
This PR introduces Terraform support for generating and publishing Calico Helm values into the per-environment “captain” repositories, similar to how Argo CD and platform values are generated today.
Changes:
- Added a new
modules/calicoTerraform module that renders a Calico values YAML viatemplatefile(). - Wired the new Calico values module into
generate-helm-values.tffor each environment. - Included the generated
calico.yamlin the set of files written to each captain repository.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| modules/calico/values.tpl | Adds the Calico Helm values template intended to be rendered by Terraform. |
| modules/calico/main.tf | Defines inputs/outputs to render values.tpl via templatefile(). |
| generate-helm-values.tf | Adds a per-environment module block to generate Calico Helm values. |
| captain-repo.tf | Publishes generated calico.yaml into each captain repository. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| calicoNetwork: | ||
| bgp: Disabled | ||
| ipPools: | ||
| - cidr: 172.16.0.0/16 |
There was a problem hiding this comment.
The IP pool CIDR is hard-coded (172.16.0.0/16). If different environments/VPCs require different pod CIDRs, this will force forks or manual edits in generated repos. Consider parameterizing this value (module variable, or deriving from environment inputs) to keep the module reusable.
| - cidr: 172.16.0.0/16 | |
| - cidr: ${calico_ip_pool_cidr_placeholder} |
There was a problem hiding this comment.
@venkatamutyala what do you think of moving this into tenant.tf ?
There was a problem hiding this comment.
@hamzabouissi that is what I was thinking as well. however how does gluekube handle it?
|
tested in my dev cluster, ref: https://github.com/glueops-rocks-opentofu-workspaces/kepler438b.onglueops.rocks/actions/runs/23897286645/job/69687686960 |
|
@allanice001 this is waiting on the metadata keyvalue pair solution we discussed with hamza before they left on vacation |
No description provided.