Skip to content

Conversation

@mjatin-dev
Copy link
Contributor

closes 1846

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'flex_admin_ui'

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@duttarnab
Copy link
Contributor

This PR is on hold. It can be addressed once the APIs are available . Issue raised for API development: https://github.com/JanssenProject/jans/issues/9907.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link
Contributor

@duttarnab duttarnab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments

'Content-Type': 'application/zip',
}
})
axios.post('/api/v1/agama-deployment/' + name, file, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use jans-config-api client for calling apis.

Copy link
Contributor Author

@mjatin-dev mjatin-dev Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duttarnab Yes, we could, but I encountered an error with the jans-config-api because we are using a file. That's why we are opting for Axios instead for some methods.

import {
getAgamaRepository,
getAgamaRepositoryFile,
} from "../../redux/features/agamaSlice";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

@duttarnab duttarnab merged commit 981ac1b into main Jan 9, 2025
7 of 9 checks passed
@duttarnab duttarnab deleted the admin-ui-1846 branch January 9, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(admin-ui): allow users to install Agama Lab community projects from Admin UI

3 participants