Skip to content

Conversation

@duttarnab
Copy link
Contributor

@duttarnab duttarnab commented Nov 18, 2025

closes #2450

Summary by CodeRabbit

  • New Features
    • Enhanced admin UI property visibility with new read-only access scope for resource management.
    • Expanded write capabilities for admin property configuration.

…nd write-security capabilities

Signed-off-by: duttarnab <arnab.bdutta@gmail.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 18, 2025

📝 Walkthrough

Walkthrough

The pull request adds two new scopes—properties.readonly and properties.write—to the adminUIResourceScopesMapping.ldif configuration file to expand admin UI permissions for read and write operations on resource properties.

Changes

Cohort / File(s) Summary
Admin UI Resource Scopes Configuration
flex-linux-setup/flex_linux_setup/templates/adminUIResourceScopesMapping.ldif
Added properties.readonly scope to READ-capable resources and properties.write scope to WRITE-capable resources in the jansScope lists

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • Issue #2450 — Appears to implement the same scope additions (properties.readonly and properties.write) to the admin UI resource scopes mapping configuration.

Possibly related PRs

  • PR #2448 — Modifies the same adminUIResourceScopesMapping.ldif file to expand jansScope entries with different scopes (data.readonly and license.readonly).

Suggested labels

comp-flex-linux-setup, kind-feature

Suggested reviewers

  • devrimyatar

Poem

🐰 Whiskers twitching with delight,
New scopes bloom in LDIF's light,
Read and write permissions grow,
Admin UI puts on quite a show! 🎩✨

Pre-merge checks and finishing touches

❌ Failed checks (3 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'read/write admin-ui config' but the actual changes add permissions for services status and license reading, which are narrower in scope. Update the title to more accurately reflect the changes: 'feat: add services status and license read permissions to admin-ui capabilities' or similar.
Linked Issues check ⚠️ Warning The raw summary shows only properties.readonly and properties.write scopes were added, but issue #2447 requires adding data.readonly scope for services status and license.readonly for Dashboard-Read capability. Verify that both required scopes (data.readonly and license.readonly) have been added to the appropriate capabilities as specified in issue #2447.
Out of Scope Changes check ⚠️ Warning The changes include properties.readonly and properties.write scopes which are not mentioned in the linked issue #2447 objectives. Either remove the properties scopes if unrelated to issue #2447, or clarify their necessity and update the issue description accordingly.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch admin-ui-2450

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mo-auto mo-auto added comp-flex-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Nov 18, 2025
@sonarqubecloud
Copy link

@devrimyatar devrimyatar merged commit 7dd724e into main Nov 18, 2025
11 of 13 checks passed
@devrimyatar devrimyatar deleted the admin-ui-2450 branch November 18, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-flex-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(admin-ui): add permission to read/write admin-ui config in read-security and write-security capabilities

3 participants