-
Notifications
You must be signed in to change notification settings - Fork 22
fix: use free bitnamilegacy images instead of paid commercial bitnami #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
📝 WalkthroughWalkthroughMultiple automation scripts and installation documentation files were updated to explicitly specify Bitnami legacy MySQL (9.4.0-debian-12-r1) and PostgreSQL (16.4.0-debian-12-r0) image repositories and tags in Helm install commands, addressing failures caused by inaccessible Bitnami commercial images. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (6)
automation/startflexdemo.sh(2 hunks)automation/startopenabankingdemo.sh(1 hunks)docs/admin/recipes/getting-started-rancher.md(1 hunks)docs/install/helm-install/amazon-eks.md(2 hunks)docs/install/helm-install/google-gke.md(2 hunks)docs/install/helm-install/microsoft-azure.md(2 hunks)
🔇 Additional comments (5)
automation/startopenabankingdemo.sh (1)
24-24: MySQL image migration is consistent.The helm install command correctly specifies
image.repository=bitnamilegacy/mysqlandimage.tag=9.4.0-debian-12-r1, consistent with other deployment scripts in the PR. This script deploys MySQL only (no PostgreSQL), so the update is appropriately scoped.docs/install/helm-install/microsoft-azure.md (1)
105-105: Cloud provider documentation consistently updated.Both PostgreSQL and MySQL helm install commands are correctly updated with bitnamilegacy images and specific tags (PostgreSQL: 16.4.0-debian-12-r0, MySQL: 9.4.0-debian-12-r1), matching the changes across GKE and EKS documentation files.
Also applies to: 133-133
docs/install/helm-install/amazon-eks.md (1)
108-108: EKS documentation correctly aligned with cloud-agnostic migration.The helm install commands for PostgreSQL and MySQL are consistently updated across all cloud platforms (EKS, GKE, Azure) with identical bitnamilegacy image references and tags. AWS-specific configurations (EBS CSI driver, nodes, regions) remain properly configured.
Also applies to: 135-135
docs/admin/recipes/getting-started-rancher.md (1)
200-200: Rancher MySQL deployment correctly migrated.The helm install command properly specifies
image.repository=bitnamilegacy/mysqlandimage.tag=9.4.0-debian-12-r1, consistent with all other deployment methods (automation scripts and cloud-provider documentation). Since this quickstart guide only covers MySQL deployment, the update is appropriately scoped.automation/startflexdemo.sh (1)
68-68: Bitnamilegacy MySQL image is publicly available.The Docker Hub API confirms that the image tag
bitnamilegacy/mysql:9.4.0-debian-12-r1exists and is publicly accessible. The helm command parameters are valid.
| if [[ $GLUU_PERSISTENCE == "PGSQL" ]]; then | ||
| sudo microk8s.kubectl get po --kubeconfig="$KUBECONFIG" | ||
| sudo helm install my-release --set auth.postgresPassword=Test1234#,auth.database=gluu -n gluu oci://registry-1.docker.io/bitnamicharts/postgresql --kubeconfig="$KUBECONFIG" | ||
| sudo helm install my-release --set auth.postgresPassword=Test1234#,auth.database=gluu,image.repository=bitnamilegacy/postgresql,image.tag=16.4.0-debian-12-r0 -n gluu oci://registry-1.docker.io/bitnamicharts/postgresql --kubeconfig="$KUBECONFIG" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Verification inconclusive
Verify bitnamilegacy PostgreSQL image availability.
The helm install command now explicitly specifies image.repository=bitnamilegacy/postgresql and image.tag=16.4.0-debian-12-r0. Ensure this legacy image is publicly available and the specified tag exists on Docker Hub or the target registry.
Run the following command to verify image availability:
🏁 Script executed:
#!/bin/bash
# Description: Verify bitnamilegacy PostgreSQL image is accessible
# Query Docker Hub API for image tags
curl -s "https://registry.hub.docker.com/v2/repositories/bitnamilegacy/postgresql/tags" | jq -r '.results[].name' | grep -E '^16\.4\.0-debian-12-r0$'Length of output: 0
I need to use alternative methods to verify this image. Let me try a few different approaches:
Let me search more specifically for the PostgreSQL 16.4.0 tag availability:
Let me search for more specific information about PostgreSQL 16.x availability in the legacy repository:
Based on my verification, I have found critical concerns about the image specification. Let me generate the rewritten review comment:
Critical issue: The bitnamilegacy/postgresql image tag may not exist or will soon become unavailable.
The bitnamilegacy repository receives no further updates or support and should only be used for temporary migration purposes. Additionally, images have already been removed from the bitnamilegacy repository unexpectedly, and the legacy repository is intended as a temporary fallback that will not receive updates, fixes, or support.
The specific tag 16.4.0-debian-12-r0 is newer than typical legacy repository versions and cannot be confirmed to exist. Examples of available tags in bitnamilegacy are older versions like postgresql:13.7.0-debian-11-r9. If this tag doesn't exist, the helm install will fail with an ImagePullBackOff error. Verify the tag exists before deployment, or consider alternative PostgreSQL sources.
🤖 Prompt for AI Agents
In automation/startflexdemo.sh around line 87, the helm command pins
image.repository=bitnamilegacy/postgresql and image.tag=16.4.0-debian-12-r0
which may not exist in the legacy repo; verify the tag before deployment and
replace the legacy image with a supported source or a known-available tag (for
example use bitnami/postgresql with a confirmed 16.x tag or pin to a validated
tag), or add a pre-deploy check that queries the registry for the tag and aborts
with a clear error if not found so the helm install won't fail with
ImagePullBackOff.
|
|
||
| ``` | ||
| helm install my-release --set auth.postgresPassword=Test1234#,auth.database=gluu -n gluu oci://registry-1.docker.io/bitnamicharts/postgresql | ||
| helm install my-release --set auth.postgresPassword=Test1234#,auth.database=gluu,image.repository=bitnamilegacy/postgresql,image.tag=16.4.0-debian-12-r0 -n gluu oci://registry-1.docker.io/bitnamicharts/postgresql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Document the bitnamilegacy image migration rationale.
The helm install commands are updated to use bitnamilegacy images (PostgreSQL 16.4.0-debian-12-r0, MySQL 9.4.0-debian-12-r1), but there is no explanatory note in the documentation about why this change was necessary or that users should use these legacy images instead of the standard Bitnami charts. Consider adding a note explaining that Bitnami commercial images are now private and this fix uses publicly available legacy versions.
Proposed documentation addition above the PostgreSQL command (around line 100):
!!! Note
Due to Bitnami's transition of their database charts to commercial/private images,
we now explicitly specify legacy Bitnami images which remain publicly available.
These changes ensure installations continue to work without authentication issues.Also applies to: 128-128
🤖 Prompt for AI Agents
In docs/install/helm-install/google-gke.md around lines 101 and 128, add a brief
explanatory note above the PostgreSQL and MySQL helm commands clarifying that
Bitnami moved some database images to commercial/private repositories and that
the docs intentionally pin publicly-available legacy Bitnami images (e.g.,
bitnamilegacy) so installations continue to work; insert a short "Note" block
stating this rationale and advising users to use the legacy image tags shown or
consult Bitnami for commercial image access.
closes #2469
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.