Skip to content

Conversation

@iromli
Copy link
Contributor

@iromli iromli commented Nov 28, 2025

The changeset sync changes, mainly dependencies for Flex all-in-one image and charts.

Closes #2486

Summary by CodeRabbit

  • New Features

    • Added configuration option to enable/disable CASA admin console.
    • Introduced CASA ingress configuration options for labels and annotations.
    • Admin UI is now enabled by default.
  • Chores

    • Updated base image version reference.

✏️ Tip: You can customize this high-level summary in your review settings.

…sole

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@iromli iromli self-assigned this Nov 28, 2025
@iromli iromli requested a review from moabu as a code owner November 28, 2025 17:51
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

📝 Walkthrough

Walkthrough

This PR adds configuration support for enabling/disabling the Casa admin console across Flex cloud-native deployments. It introduces new Helm chart values fields (casa.adminEnabled, casa.ingress.*), updates ConfigMap templates to expose these settings as environment variables (CN_CASA_ADMIN_ENABLED), and bumps a Docker image source version reference.

Changes

Cohort / File(s) Summary
Helm chart documentation
charts/gluu-all-in-one/README.md, charts/gluu/README.md
Added documentation for new casa.adminEnabled configuration option and casa ingress settings
Values configuration
charts/gluu-all-in-one/values.yaml, charts/gluu/values.yaml
Introduced casa.adminEnabled boolean flag and casa.ingress.* properties for controlling Casa admin console and ingress endpoints
Values schema
charts/gluu/values.schema.json
Added adminEnabled property definition to casa object schema for validation
ConfigMap templates
charts/gluu-all-in-one/templates/configmap.yaml, charts/gluu/charts/config/templates/configmaps.yaml
Added CN_CASA_ADMIN_ENABLED environment variable entries sourced from casa.adminEnabled values
Docker image version
docker-flex-all-in-one/Dockerfile
Updated JANS_SOURCE_VERSION from 2440f1c284173c0b4f7c4fd4ef1577ce39c385ad to f9a01573beed5495f5e2d30e88aef7a87d9d2a19

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

These are primarily homogeneous configuration additions following consistent patterns across similar files. The changes involve adding new fields to values files and corresponding ConfigMap entries with no complex logic changes.

Possibly related PRs

Suggested labels

comp-charts-flex, comp-docker-admin-ui, kind-dependencies

Suggested reviewers

  • moabu

Poem

🐰 A flag for Casa, now it can dance,
adminEnabled takes a whimsical chance,
Ingress unfolds with labels so bright,
The admin console shines with delight! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Out of Scope Changes check ❓ Inconclusive The Dockerfile version update to JANS_SOURCE_VERSION appears to be a dependency synchronization unrelated to the Casa admin console feature, though the PR description mentions syncing dependency updates. Clarify whether the JANS_SOURCE_VERSION update in the Dockerfile is intended as part of this feature or if it should be split into a separate PR for dependency updates.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: adding support for enabling/disabling the Casa admin console, which aligns with all modified files introducing casa.adminEnabled configuration.
Linked Issues check ✅ Passed The PR successfully implements the objective from issue #2486 by adding casa.adminEnabled configuration across Helm charts (values.yaml, configmaps, schema) and updating Docker image version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cn-casa-administrable

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe2881e and c2e1a5b.

📒 Files selected for processing (8)
  • charts/gluu-all-in-one/README.md (2 hunks)
  • charts/gluu-all-in-one/templates/configmap.yaml (1 hunks)
  • charts/gluu-all-in-one/values.yaml (1 hunks)
  • charts/gluu/README.md (2 hunks)
  • charts/gluu/charts/config/templates/configmaps.yaml (1 hunks)
  • charts/gluu/values.schema.json (1 hunks)
  • charts/gluu/values.yaml (1 hunks)
  • docker-flex-all-in-one/Dockerfile (1 hunks)
🔇 Additional comments (9)
docker-flex-all-in-one/Dockerfile (1)

68-68: Jans source version update confirmed to include Casa admin console support.

The commit SHA has been updated to pull in 24 upstream commits from the Jans repository. Verification confirms the new version includes the Casa admin console feature (feat(cloud-native): add support for enabling/disabling Casa admin console #12771), which aligns with the PR objectives. The commits are recent, properly signed, and include related Casa dependency updates.

charts/gluu/charts/config/templates/configmaps.yaml (1)

206-206: Verify intentionality of unconditional ConfigMap entry vs. conditional CASA loggers above.

The CN_CASA_ADMIN_ENABLED flag is rendered unconditionally, while the CN_CASA_APP_LOGGERS block above it (line 195) is conditionally rendered based on .Values.global.casa.enabled. If the admin flag should only be present when Casa is enabled, it should be wrapped in the same conditional. Alternatively, if the flag is intentionally always present (as a feature toggle independent of the service enablement), this is acceptable.

Confirm this is intentional behavior.

charts/gluu/values.yaml (1)

1099-1100: LGTM!

The new adminEnabled boolean flag is correctly placed under global.casa with appropriate documentation and defaults to true (enabled by default). The type and structure align with existing CASA configuration patterns.

charts/gluu/README.md (1)

418-418: LGTM!

The documentation entry for global.casa.adminEnabled is accurate, complete, and follows the existing format. The type (bool), default value (true), and description are all correct.

charts/gluu-all-in-one/templates/configmap.yaml (1)

181-181: Verify value path consistency between gluu and gluu-all-in-one charts.

The gluu chart's config template references .Values.global.casa.adminEnabled (line 206 in charts/gluu/charts/config/templates/configmaps.yaml), but this file references .Values.casa.adminEnabled. While this pattern is expected for different chart hierarchies, ensure that:

  1. charts/gluu-all-in-one/values.yaml explicitly defines casa.adminEnabled
  2. Both values are kept synchronized or the divergence is intentional
  3. The value propagation is documented (if one should mirror the other)

Additionally, like the parent chart, this entry is unconditional, while CN_CASA_APP_LOGGERS above it is conditional on casa.enabled. Verify this is intentional.

charts/gluu/values.schema.json (1)

796-799: Schema property correctly defined with proper structure and description.

The adminEnabled boolean property is properly positioned under global.casa.properties and follows the established schema pattern for enable/disable flags.

One clarification needed: The schema defines global.casa.adminEnabled, but the corresponding values file (charts/gluu-all-in-one/values.yaml) defines the property at the top level as casa.adminEnabled (not nested under a global section). Verify that the Helm chart structure correctly maps this value through subcharts. Does the all-in-one chart pass top-level casa.* values as global.casa.* to dependency charts?

charts/gluu-all-in-one/README.md (1)

126-126: Documentation correctly added with clear description and matching defaults.

The README table entry for casa.adminEnabled is properly formatted, accurately described, and defaults to true, which aligns with the values file and enables the Casa admin console by default.

charts/gluu-all-in-one/values.yaml (2)

406-407: Configuration property correctly added with consistent naming and clear default.

The casa.adminEnabled property is properly integrated into the values file with appropriate default (true), correct indentation, and positioning that maintains logical grouping of Casa configuration options. The comment follows existing conventions and distinguishes this feature flag from the general chart enablement flag (casa.enabled).


1-1: ConfigMap template integration is already correctly implemented; verification request is unfounded.

The ConfigMap templates referenced in the PR summary do exist and properly integrate the casa.adminEnabled configuration:

  • charts/gluu-all-in-one/templates/configmap.yaml (line 181): CN_CASA_ADMIN_ENABLED: {{ .Values.casa.adminEnabled | quote }}
  • charts/gluu/charts/config/templates/configmaps.yaml (line 206): CN_CASA_ADMIN_ENABLED: {{ .Values.global.casa.adminEnabled | quote }}

The casa.adminEnabled value is defined in both values files (charts/gluu-all-in-one/values.yaml line 407 and charts/gluu/values.yaml line 1100), and the ConfigMap templates correctly reference and expose these values as the CN_CASA_ADMIN_ENABLED environment variable. No action required.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-charts-flex Touching folder /flex-cn-setup/pygluu/kubernetes/templates/helm kind-feature Issue or PR is a new feature request labels Nov 28, 2025
@iromli iromli requested a review from misba7 November 28, 2025 18:00
@moabu moabu merged commit e664cbb into main Dec 1, 2025
15 of 18 checks passed
@moabu moabu deleted the cn-casa-administrable branch December 1, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-documentation Documentation needs to change as part of issue or PR comp-charts-flex Touching folder /flex-cn-setup/pygluu/kubernetes/templates/helm kind-feature Issue or PR is a new feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(cloud-native): add support for enabling/disabling Casa admin console

4 participants