Skip to content

Conversation

@moabu
Copy link
Member

@moabu moabu commented Dec 2, 2025

JanssenProject/jans#12788

Summary by CodeRabbit

  • Chores
    • Updated Docker build configurations to use a new asset source version across multiple services, ensuring consistent and reproducible builds.

✏️ Tip: You can customize this high-level summary in your review settings.

@moabu moabu requested a review from iromli as a code owner December 2, 2025 12:35
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Both Dockerfiles update the JANS_SOURCE_VERSION environment variable to the same commit hash (5343272241b17a3e4efa7d998ae031f6ad512aa1), changing which assets are checked out from the monorepo during the build process. No logic or control flow changes are present.

Changes

Cohort / File(s) Summary
Version Updates
docker-admin-ui/Dockerfile, docker-flex-all-in-one/Dockerfile
Updated JANS_SOURCE_VERSION environment variable to 5343272241b17a3e4efa7d998ae031f6ad512aa1 to specify source assets for build

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple, homogeneous configuration updates with no logic changes
  • Both files receive the same environment variable update

Poem

🐰 Two Dockerfiles, one happy hash,
New source commits make a dash,
Assets updated, bright and clean,
Best build version ever seen,
Hop along, the images flash! 🐳

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-support-cloud-auth

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e4ece9 and d82b0b0.

📒 Files selected for processing (2)
  • docker-admin-ui/Dockerfile (1 hunks)
  • docker-flex-all-in-one/Dockerfile (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@moabu moabu merged commit f03df69 into main Dec 2, 2025
5 of 9 checks passed
@moabu moabu deleted the chore-support-cloud-auth branch December 2, 2025 12:35
@mo-auto mo-auto added comp-docker-admin-ui Component affected by issue or PR kind-dependencies Pull requests that update a dependency file labels Dec 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-docker-admin-ui Component affected by issue or PR kind-dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants