fix(admin-ui): resolve data inconsistency issues in My Profile (#2599) #2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 WalkthroughWalkthroughThis PR removes the Auth Server reports route and components, adds user attribute translations (en/es/fr/pt), refactors ProfilePage (memoization, rendering helpers, auth state), replaces CardFooter with GluuFormFooter in client wizard, and changes navigation usage to include navigateBack. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mo-auto
added
comp-admin-ui
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@admin-ui/plugins/auth-server/components/Clients/ClientWizardForm.js`:
- Around line 221-223: The Next/Previous bounds use the full sequence (which
always contains ClientActiveTokens) so in create flow isLastStep is never true
and Next can advance to a hidden step; update the logic to derive an activeSteps
array based on isEdit (filter out ClientActiveTokens when isEdit is false) and
use activeSteps for computing isFirstStep, isLastStep, and for
advancing/retreating currentStep (replace usages of sequence in those checks and
next/prev handlers with activeSteps); ensure currentStep comparisons use
activeSteps[0] and activeSteps[activeSteps.length - 1] and handle edge cases
where currentStep might not be in activeSteps.
admin-ui/plugins/auth-server/components/Clients/ClientWizardForm.js
Outdated
Show resolved
Hide resolved
faisalsiddique4400
changed the title
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@admin-ui/plugins/auth-server/components/Clients/ClientWizardForm.js`:
- Around line 537-578: The GluuFormFooter currently has isLoading hardcoded to
false; replace this with a real loading state (e.g., local state isApplying or
isLoading) and wire it into the submission flow: add a state variable in the
component, set it true at the start of handleApply and false on success/error
(and ensure any async branches reset it), then pass that variable to the
GluuFormFooter isLoading prop (instead of false) so the footer reflects the
actual submit/loading status; reference GluuFormFooter, handleApply, and
modifiedFields when making these changes.
- Line 265: In ClientWizardForm remove the no-op useEffect that references
cedarPermissions; delete the line "useEffect(() => {}, [cedarPermissions])" so
there is no empty effect running on cedarPermissions changes—this eliminates
unnecessary re-renders and overhead in the ClientWizardForm component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(admin-ui): resolve data inconsistency issues in My Profile (#2599)
Summary
This PR fixes multiple data consistency and usability issues across Assets, Clients, and My Profile sections of the Admin UI. These issues were causing incorrect validation behavior, missing navigation controls, and incomplete data rendering.
Issues Addressed
My Profile
Fix Details
Result
Additional Notes
These changes improve form correctness and navigation flow, while addressing user-facing inconsistencies reported across multiple modules.
🔗 Ticket
Closes: #2599
Summary by CodeRabbit
Bug Fixes
New Features
Improvements
Removed Features
✏️ Tip: You can customize this high-level summary in your review settings.