fix(parity): honor healthcheck start_period/interval in dependency wait#436
Merged
Conversation
wait_healthy polled a hard-coded 2s for retries probes, ignoring the compose healthcheck interval and start_period. A service with a long start_period (slow boot) could be declared timed-out before it had a chance to become healthy, diverging from docker-compose depends_on: service_healthy. Now poll at the interval (>=1s, else 2s) and add extra probes spanning start_period; defaults are unchanged (2s x 30 = 60s). Also document the single-replica container-naming divergence (podup omits the -1 suffix docker-compose v2 always appends) in docker-migration.md. Closes #418. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
This was referenced Jun 17, 2026
Closed
Jaro-c
added a commit
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #418 (the remaining items; item 1 — restart
any→always— shipped in #422).Item 2 — healthcheck timing
wait_healthypolled a hard-coded 2s forretriesprobes, ignoring the composeintervalandstart_period. A service with a longstart_periodcould be declared timed-out before it had a chance to boot — diverging from docker-composedepends_on: { condition: service_healthy }. Now polls at theinterval(>=1s, else 2s) and adds probes spanningstart_period. Defaults unchanged (2s × 30 = 60s) so existing behaviour is preserved. Logic extracted to a purehealth_poll_planwith unit tests;depends_on_service_healthyintegration test passes on real Podman.Item 3 — container naming
Documented (not changed): a single-replica service is
<project>-<service>; docker-compose v2 always appends-1. Added todocs/docker-migration.mdso migrating users know. Changing the scheme would rename/recreate every existing container, so it stays documented rather than altered.Closes #418.