fix: reject unset env secret and world-readable mode bits#87
Open
Jaro-c wants to merge 1 commit into
Open
Conversation
SEC-006: environment: secrets and configs silently produced a zero-byte file when the referenced env var was absent, enabling auth bypass. Return Err instead so the process fails closed. SEC-008: apply_mode accepted any mode including 0o777, downgrading a secret file to world-readable. Reject any mode with group- or world-read bits (mode & 0o044 != 0). Closes #76 Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
Jaro-c
added
type:security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environment:secrets/configs now fail with an error when the referenced env var is not set, instead of silently writing a zero-byte file that would allow auth bypassapply_moderejects any mode with group-read (g+r) or world-read (o+r) bits — the whole point of a secret file is that only the owner can read itTest plan
cargo test --libpasses (130 tests, 3 new)environment:secret with unset var returnsErr(...env var '...' which is not set)0o777,0o644,0o640are rejected;0o400,0o600passCloses #76