fix: limit extends chain depth to prevent stack overflow DoS#91
Open
Jaro-c wants to merge 1 commit into
Open
Conversation
Closes #80 Adds a MAX_EXTENDS_DEPTH (16) guard to both resolve_one_extends and resolve_one_extends_in_memory. Any extends chain deeper than 16 levels returns a clear error instead of recursing until stack exhaustion. Two tests cover the boundary: 15 hops accepted, 16 hops rejected. Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_EXTENDS_DEPTH = 16constantresolve_one_extendsandresolve_one_extends_in_memorycheck the depth counter on entry and return a clearComposeError::Extendsif exceeded — no unbounded recursion on crafted compose filesCloses #80
Test plan
cargo testpasses (446 tests)extends_chain_within_depth_limitpassesextends_chain_exceeds_depth_limitpasses