Skip to content

Relative Accessible Surface Area #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

KirkD-Glysade
Copy link
Contributor

Adds RASA calculations and visualizations. Parallel with similar PR in DataFxnPylibTest and DataFxns.

Copy link
Member

@jones-gareth jones-gareth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Just the one error handling item.

for sequence_residue_number, sequence_residue in enumerate(sequence.seq):
if sequence_residue != '-':
if sequence_residue != structure_residues[structure_residue_number]:
# send a notification and then fail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you raise an error here that will fail the data function and create a Spotfire notification

@KirkD-Glysade
Copy link
Contributor Author

Looks nice. Just the one error handling item.

Nice catch. I'll fix that one and resubmit.

@KirkD-Glysade
Copy link
Contributor Author

Looks nice. Just the one error handling item.

Nice catch. I'll fix that one and resubmit.

Done. Clearly something I intended to do and forgot to go back and finish. Thanks for catching that one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants