Skip to content

implement Into<Box<str>> #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GnomedDev merged 2 commits into from
Sep 12, 2025
Merged

implement Into<Box<str>> #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e4364
implement Into<Box<str>>
Joshix-1 Sep 12, 2025
1578063
remove unused import
Joshix-1 Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/string.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use alloc::{
borrow::{Cow, ToOwned},
boxed::Box,
string::{String, ToString},
string::{String},
sync::Arc,
};
use core::{borrow::Borrow, fmt::Write as _, hash::Hash, str::FromStr};
Expand Down Expand Up @@ -315,12 +315,18 @@ impl<LenT: ValidLength> From<char> for FixedString<LenT> {
}

impl<LenT: ValidLength> From<FixedString<LenT>> for String {
fn from(value: FixedString<LenT>) -> Self {
Box::<str>::from(value).into()
}
}

impl<LenT: ValidLength> From<FixedString<LenT>> for Box<str> {
fn from(value: FixedString<LenT>) -> Self {
match value.0 {
FixedStringRepr::Inline(a) => a.as_str().into(),
FixedStringRepr::Static(a) => a.as_str().into(),
// SAFETY: Self holds the type invariant that the array is UTF-8.
FixedStringRepr::Heap(a) => unsafe { String::from_utf8_unchecked(a.into()) },
FixedStringRepr::Inline(a) => a.as_str().to_string(),
FixedStringRepr::Static(a) => a.as_str().to_string(),
FixedStringRepr::Heap(a) => unsafe { alloc::str::from_boxed_utf8_unchecked(a.into()) },
}
}
}
Expand Down