Skip to content

Conversation

@Jasrags
Copy link
Contributor

@Jasrags Jasrags commented Aug 19, 2025

Description

Fixing log levels for Server start and stop messages

Changes

  • Changed Starting server message, from ERROR to INFO
  • Changed Stopping server message, from ERROR to INFO

@Jasrags Jasrags self-assigned this Aug 19, 2025
@Jasrags Jasrags requested a review from Volte6 as a code owner August 19, 2025 23:21
@Jasrags Jasrags requested review from MorquinDevlar and Copilot and removed request for Volte6 August 19, 2025 23:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes log level inconsistency by changing server lifecycle messages from ERROR to INFO level. Server start and stop messages are normal operational events that should be logged at INFO level rather than ERROR level, which is reserved for actual error conditions.

  • Changed server startup message log level from ERROR to INFO
  • Changed server shutdown message log level from ERROR to INFO

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@MorquinDevlar MorquinDevlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been wondering about this for a long time, but never got around to tracking down where it needed changing.

Thanks :)

@Jasrags Jasrags merged commit 9e7e60e into master Aug 20, 2025
7 checks passed
@Jasrags Jasrags deleted the fixing_log_levels branch August 20, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants