Skip to content

Fixing issue #430 - ephemeralRoomIdMinimum would overflow on 32bit systems #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorquinDevlar merged 1 commit into from
Aug 21, 2025
Merged

Fixing issue #430 - ephemeralRoomIdMinimum would overflow on 32bit systems #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions internal/rooms/ephemeral.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ import (
)

const (
ephemeralChunksLimit = 100 // The maximum number of ephemeral chunks that can be created
ephemeralChunkSize = 250 // The maximum quantity of ephemeral room's that can be copied/created in a given chunk.
roomIdMin32Bit = 1000000000 // 1,000,000,000
ephemeralChunksLimit = 100 // The maximum number of ephemeral chunks that can be created
ephemeralChunkSize = 250 // The maximum quantity of ephemeral room's that can be copied/created in a given chunk.
roomIdMin32Bit = 1000000 // 1,000,000 - Safe for 32-bit systems (was 1,000,000,000 which overflows when multiplied by 1000)
)

var (
ephemeralRoomIdMinimum = roomIdMin32Bit // 1,000,000,000 is assuming 32 bit. the init() function may override this value.
ephemeralRoomIdMinimum = roomIdMin32Bit // 1,000,000 is assuming 32 bit. the init() function may override this value to 1,000,000,000 on 64-bit systems.
ephemeralRoomChunks = [ephemeralChunksLimit][]int{} // map of ranges to actual rooms. If empty, slot is available.
originalRoomIdLookups = map[int]int{} // a map of ephemeralId's to their original RoomId's, for special purposes
// errors
Expand Down Expand Up @@ -232,6 +232,6 @@ func GetOriginalRoom(roomId int) int {

func init() {
if math.MaxInt > ephemeralRoomIdMinimum*1000 {
ephemeralRoomIdMinimum = ephemeralRoomIdMinimum * 1000 // 1,000,000,000 => // 1,000,000,000,000
ephemeralRoomIdMinimum = ephemeralRoomIdMinimum * 1000 // 1,000,000 => 1,000,000,000 on 64-bit systems
}
}