Skip to content

[CI] Fix: webclient JavaScript lint#487

Merged
CaseyLabs merged 1 commit into
GoMudEngine:masterfrom
clabs-public-forks:fix/webclient-jshint
Apr 17, 2026
Merged

[CI] Fix: webclient JavaScript lint#487
CaseyLabs merged 1 commit into
GoMudEngine:masterfrom
clabs-public-forks:fix/webclient-jshint

Conversation

@CaseyLabs

Copy link
Copy Markdown
Collaborator

Description

Why

  • Fixes the upstream lint failure from GoMudEngine/GoMud run 24554839212, job 71788680015.
  • The failing build reported 9 JSHint errors in the webclient browser modules.
  • The failures are lint-only issues, not behavior changes.

Changes

  • Allow intentional Function constructor use in triggers.js.
  • Declare browser globals used by modular webclient files.
  • Add the missing semicolon in webclient-core.js.

Validation

  • make js-lint
  • make validate
  • make test

@CaseyLabs CaseyLabs changed the title Fix webclient JavaScript lint Fix: webclient JavaScript lint Apr 17, 2026
@CaseyLabs
CaseyLabs marked this pull request as ready for review April 17, 2026 08:17
@CaseyLabs
CaseyLabs requested a review from Volte6 as a code owner April 17, 2026 08:17
@CaseyLabs CaseyLabs changed the title Fix: webclient JavaScript lint Fix: CI - webclient JavaScript lint Apr 17, 2026
@CaseyLabs CaseyLabs changed the title Fix: CI - webclient JavaScript lint Fix: [CI] webclient JavaScript lint Apr 17, 2026
@CaseyLabs CaseyLabs changed the title Fix: [CI] webclient JavaScript lint [CI] Fix: webclient JavaScript lint Apr 17, 2026

@Volte6 Volte6 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The linting directives are kinda annoying to have to maintain :/

@CaseyLabs
CaseyLabs merged commit 7570664 into GoMudEngine:master Apr 17, 2026
6 checks passed
@CaseyLabs
CaseyLabs deleted the fix/webclient-jshint branch April 17, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants