Added fix(#1c081b9): detect the drive letter and don't replace its co… #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lon in Windows system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An adaptation of a previous commit about Windows that replaces ":" by "_" that leads to an error when using the "pyrdp-convert" with the error message:
[-] Failed to handle data, continuing anyway: [Errno 2] No such file or directory: 'C_\\Windows\\Temp\\The 1st colon is also replaced, leading to an invalid path in Windows that expected "C:"
This fix aim to ignore drive colon, but keep replacing the other ":".
For other systems, they remains unchanged