Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moving time methods to ModLoaderTime #346

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

refactor: moving time methods to ModLoaderTime #346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53d7ca5
Spliting Date & Time Methods in to Dedicated Class
AlajeBash Oct 19, 2023
76505f1
Update addons/mod_loader/api/time.gd
AlajeBash Oct 19, 2023
364600c
Update addons/mod_loader/api/time.gd
AlajeBash Oct 19, 2023
c66631d
Update addons/mod_loader/api/time.gd
AlajeBash Oct 19, 2023
4f82dd9
resolved the suggestions
AlajeBash Oct 19, 2023
a73641f
Update addons/mod_loader/api/time.gd
AlajeBash Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions addons/mod_loader/api/log.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,22 +446,21 @@ class ModLoaderLogCompare:
# Internal Date Time
# =============================================================================

# Returns the current time as a string in the format hh:mm:ss
static func _get_time_string() -> String:
var date_time := Time.get_datetime_dict_from_system()
return "%02d:%02d:%02d" % [ date_time.hour, date_time.minute, date_time.second ]
# Import the ModLoaderTime class
const ModLoaderTime = preload("time.gd")

# This create an instance of ModLoaderTime
var time_utils = ModLoaderTime.new()

# Returns the current date as a string in the format yyyy-mm-dd
static func _get_date_string() -> String:
var date_time := Time.get_datetime_dict_from_system()
return "%s-%02d-%02d" % [ date_time.year, date_time.month, date_time.day ]


# Returns the current date and time as a string in the format yyyy-mm-dd_hh:mm:ss
static func _get_date_time_string() -> String:
return "%s_%s" % [ _get_date_string(), _get_time_string() ]
# ModLoaderTime instance Function
func _ready():
var time_str = time_utils._get_time_string()
var date_str = time_utils._get_date_string()
var date_time_str = time_utils._get_date_time_string()

print("Time: ", time_str)
print("Date: ", date_str)
print("Date-Time: ", date_time_str)


# Internal File
Expand Down
17 changes: 17 additions & 0 deletions addons/mod_loader/api/time.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
extends Node

Copy link
Member

@KANAjetzt KANAjetzt Oct 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One empty line missing.
If you are interested you can read up on the GDScript style guide here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty line is still missing.

class_name ModLoaderTime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extends Node
class_name ModLoaderTime
class_name ModLoaderTime
extends Node

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add a short comment above the class_name that describes this class.
See the top comment of log.gd for an example.


# Returns the current time as a string in the format hh:mm:ss
static func _get_time_string() -> String:
var date_time := Time.get_datetime_dict_from_system()
return "%02d:%02d:%02d" % [ date_time.hour, date_time.minute, date_time.second ]

# Returns the current date as a string in the format yyyy-mm-dd
static func _get_date_string() -> String:
var date_time := Time.get_datetime_dict_from_system()
return "%s-%02d-%02d" % [ date_time.year, date_time.month, date_time.day ]

# Returns the current date and time as a string in the format yyyy-mm-dd_hh:mm:ss
static func _get_date_time_string() -> String:
return "%s_%s" % [ _get_date_string(), _get_time_string() ]