Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mod loader version check #491

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Dec 16, 2024

leftover todo from #416

helps prevent crashes when the mod loader was updated (to support hooks for example) but the game did not receive a major update.

@Qubus0 Qubus0 added enhancement New feature or request validation Feature to make things safe and predictable 4.x labels Dec 16, 2024
@Qubus0 Qubus0 requested a review from KANAjetzt December 16, 2024 14:51
@Qubus0 Qubus0 self-assigned this Dec 16, 2024
@Qubus0
Copy link
Collaborator Author

Qubus0 commented Dec 19, 2024

hm this might have to be rethought since the mod loader should be downward compatible while we assume that the game is not 🤔

@KANAjetzt
Copy link
Member

Maybe always display a warning if a mod loader version mismatch is detected.

Alternatively, warn for a major version difference of -1 and disable the mod for a major version difference of -2, since we say that deprecated methods are removed in the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x enhancement New feature or request validation Feature to make things safe and predictable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants