-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use GDRE for self setup #533
Open
KANAjetzt
wants to merge
10
commits into
GodotModding:4.x
Choose a base branch
from
KANAjetzt:refactor_self_setup_GDRE
base: 4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the setup to a setup scene. This setup scene is loaded by the `--script`.
This reverts commit 95ce66c.
Qubus0
reviewed
Feb 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this did not include gdre in the commit - i assume that changes the steps required for the setup? could you add those to the description for testing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Currently, self-setup (and Mod Hooks in general) only works if the game exports GDScript in plain text. Before Godot 4.3, this is always the case.
Note
Injection is currently only supported for Windows.
This PR replaces PckExplorer with GDRE.
Tested With
Downloads
Download the zip file for your operating system and unpack the
addons
directory next to the game executable.ModLoader-Self-Setup_7.0.0-WIN.zip