Forward inputs to XR rigs parented under a T5Manager - #76
Open
Jonathan-Stevens wants to merge 1 commit into
Open
Forward inputs to XR rigs parented under a T5Manager#76Jonathan-Stevens wants to merge 1 commit into
Jonathan-Stevens wants to merge 1 commit into
Conversation
Collaborator
|
Would you mind rebasing these changes onto the current main so that the github CI can run? |
Jonathan-Stevens
force-pushed
the
upstream/input-forwarding
branch
from
October 7, 2025 20:22
4a96705 to
0f56161
Compare
Collaborator
|
This is a problem that needs to get solved and this solution works. However, I'm not as familiar the Godot input system as I should be and I am worried that there are subtilities here that I'm not aware of. I think I would feel better if we put the forwarding behind an option to turn it on and off. |
Jonathan-Stevens
force-pushed
the
upstream/input-forwarding
branch
from
October 17, 2025 01:49
0f56161 to
4de8633
Compare
This enables nodes within a XR rig to receive input events when they implement _input().
Jonathan-Stevens
force-pushed
the
upstream/input-forwarding
branch
from
October 17, 2025 01:50
4de8633 to
67801b7
Compare
patrickdown
reviewed
Nov 4, 2025
| get_parent().add_child.call_deferred(glasses_node) | ||
|
|
||
| func _input(event): | ||
| # JSTEVENS@T5: As I'm porting this logic from C#, my instinct is to mirror |
Collaborator
There was a problem hiding this comment.
You do need to call super(event) but in this case there is no _input method in the base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this fix for #75, T5Manager now forwards the events that it observes during
_input()to each child XR rig that it is aware of.This enables nodes within a XR rig to receive input events.