Update the plugin to Godot v2 Android plugin - #43
Merged
Conversation
Member
|
Cool, so we'll also need to do another test release once merged. :) |
Member
|
@m4gr3d the upstream PR has been merged into master, is there anything left to do here or should we take this out of draft? |
m4gr3d
force-pushed
the
refactor_to_v2_android_plugin
branch
from
September 6, 2023 06:30
44c4458 to
87a7aca
Compare
m4gr3d
marked this pull request as ready for review
September 6, 2023 06:32
Collaborator
Author
Ready for review! |
BastiaanOlij
approved these changes
Sep 7, 2023
BastiaanOlij
left a comment
BastiaanOlij
left a comment
Member
There was a problem hiding this comment.
Tested both on Quest Pro and PICO 4, looks like it all works :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update based on godotengine/godot#80740.
Will be removed from draft once that PR is landed.