Skip to content

⚡ Fix excessive Redux dispatches in Composition component #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Godzilla675 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

⚡ Fix excessive Redux dispatches in Composition component #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/web/app/components/editor/player/remotion/sequence/composition.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const Composition = () => {
if (Math.abs(currentTimeInSeconds - previousTime.current) > THRESHOLD) {
if (currentTimeInSeconds !== undefined) {
dispatch(setCurrentTime(currentTimeInSeconds));
previousTime.current = currentTimeInSeconds;
}
Comment on lines 20 to 23

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The check currentTimeInSeconds !== undefined is redundant. currentTimeInSeconds is calculated as frame / fps, where frame is a number from useCurrentFrame() and fps is a constant number. The result will always be a number, so this check is unnecessary. You can simplify the code by removing this conditional block.

            dispatch(setCurrentTime(currentTimeInSeconds));
            previousTime.current = currentTimeInSeconds;

}

Expand Down
1 change: 1 addition & 0 deletions test_tsx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
console.log('Hello from tsx')

Copilot AI Feb 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file appears to be a test or debugging artifact that was accidentally committed. It contains only a console.log statement and doesn't serve any purpose in the production codebase. This file should be removed before merging.

Suggested change
console.log('Hello from tsx')

Copilot uses AI. Check for mistakes.

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This file appears to be a temporary test file that is not related to the purpose of this pull request. It should be removed before merging to keep the codebase clean.

Loading