API access. Swagger return. #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks! Will try that out later today. |
|
If I've got the pull request thing right, I'll start looking at making the radio button sticky, and adding in things like career choice if you are moving on to subsector generation. |
|
Yes, you got it right. The functionality I want to add is:
|
|
So I've got an update for sticky radio buttons. It's unclear to me if it added it to the existing pull request, or how I create a new pull request when this one hasn't been merged. If you are OK with the API additions, can you merge? Then it will be clear if I have to do another one for the sticky radio buttons. |
|
Yeah, I did another update for career choice, and now I see conflicts. I'll hold off until we get the merge sequence sorted out. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added in API access to your logic on the /api/chargen URL. It returns the character in JSON.
The format of the JSON and the path to it is defined in the api.swagger doc.
I also made the api self documenting. When you browse to /api it returns to you the swagger.
You can cut and paste this into editor.swagger.io, or open the URL from that site directly to view pretty documentation for the API, and generate stubs to call it in many languages.