Gomboc Fix for #11 - aws/terraform/s3-default#12
Open
gomboc-community-dev[bot] wants to merge 2 commits intojacobgombocai-patch-2from
Open
Conversation
![gomboc-community-dev[bot]](https://avatars.githubusercontent.com/u/143810953?s=60&v=4){kind=small}
| source = "files/test.txt" | ||
| } | ||
| resource "aws_s3_bucket_public_access_block" "my_aws_s3_bucket_public_access_block_aws_s3_bucket_uut" { | ||
| bucket = aws_s3_bucket.uut.id |
Author
There was a problem hiding this comment.
l.60Recommended applying Prevent Public Access via Explicit Setting:- Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
- CIS Critical Security Controls v8.1
Leave feedback (ref: eca41f266f751ed349458c3cd334235d59dd7f457f0ccd4f199c2530a081a704)
| } | ||
| resource "aws_s3_bucket_public_access_block" "my_aws_s3_bucket_public_access_block_aws_s3_bucket_uut" { | ||
| bucket = aws_s3_bucket.uut.id | ||
| ignore_public_acls = true |
Author
There was a problem hiding this comment.
l.61Recommended applying Prevent Public Access via Explicit Setting:- Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
- CIS Critical Security Controls v8.1
Leave feedback (ref: eca41f266f751ed349458c3cd334235d59dd7f457f0ccd4f199c2530a081a704)
| ignore_public_acls = true | ||
| } | ||
| resource "aws_s3_bucket_versioning" "my_aws_s3_bucket_versioning_aws_s3_bucket_uut" { | ||
| bucket = aws_s3_bucket.uut.id |
Author
There was a problem hiding this comment.
l.64Recommended applying Data Versioning:- Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
Leave feedback (ref: 4a929e622cad2d797ae13276acd699f65ca334eae2c9d1f86e9dfb81ac55ad46)
| resource "aws_s3_bucket_versioning" "my_aws_s3_bucket_versioning_aws_s3_bucket_uut" { | ||
| bucket = aws_s3_bucket.uut.id | ||
| versioning_configuration { | ||
| status = "Enabled" |
Author
There was a problem hiding this comment.
l.66Recommended applying Data Versioning:- Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
Leave feedback (ref: 4a929e622cad2d797ae13276acd699f65ca334eae2c9d1f86e9dfb81ac55ad46)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix was produced in response to #11 on the following target:
These recommendations come from the following benchmarks