Driver assist to pose#39
Conversation
|
See the note on #38 |
|
Other than documentation, lgtm. There's a lot of stuff in there that might be pretty confusing that we'll need to document in a way that makes it easier for new team members to figure out what in the world is going on, but it all makes sense, just takes a good amount of java knowledge. This is a SUPER good start to driver assistance, better visualization in advantageScop, and apriltag prioritization, but one thing I would say we could probably change right now is just changing the name of NTDouble to NTMeasure, since it is effectively logging a Measure to NT. Maybe even TunableMeasure, that along with some javadoc would get the point across that it's a Measure logged in NT that can also be changed from a NT client. ALSO, it might be useful to give NTDouble a set method so code will have some way to publish its own values to NT without having to restart code completely. That could also open up some uses for changing setpoints from a NT client which sounds pretty cool though also kinda scary Other than the NTDouble suggestion (which I could just do in another PR), I think we're good to resolve conflicts and merge also in usecases other than setting tuning gains from NT calling it TunableMeasure might seem a little weird now that I'm thinking about idk I'm torn on that, I would at least like to make it more obvious that the value can be changed from NT somehow, maybe javadoc would be enough for that idk |
2 participants
No description provided.