Bug: Resolve stewards UI issues. Closes #275 #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ight to avoid cropping in desktop.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @vtamara - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changes look good, but I'm not sure about renaming 'steward' to 'recipient' - have you considered the implications of this change across the entire application?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Missing Default Title for Non-Stream Donations ▹ view | |
|
Rigid List Height Constraint ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| packages/app/src/components/TransactionList/ClaimTransactionListItem.tsx | ✅ |
| packages/app/src/components/TransactionList/TransactionListItem.tsx | ✅ |
| packages/app/src/pages/ViewStewardsPage.tsx | ✅ |
| packages/app/src/components/StewardsList/StewardsList.tsx | ✅ |
| packages/app/src/components/AboutCard.tsx | ✅ |
| packages/app/src/components/ViewCollective.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic including drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Documentation ❌ Logging ❌ Error Handling ❌ Readability ❌ Design ✅ - Potentially Major Issues Only Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
| const formattedTimestamp = moment(timeStamp * 1000).format('MM.DD.YYYY HH:mm'); | ||
|
|
||
| const title = !isDonation ? (isUBIPool ? 'Recipient claim' : 'Steward Payout') : isStream; | ||
| const title = !isDonation ? (isUBIPool ? 'Recipient claim' : 'Recipient Payout') : isStream; |
There was a problem hiding this comment.
Missing Default Title for Non-Stream Donations 
Tell me more
What is the issue?
The title assignment logic fails to handle the case when isDonation is true and isStream is undefined or falsy, resulting in an undefined title.
Why this matters
This could lead to UI inconsistencies and potential rendering issues when displaying transaction types for donations without streams.
Suggested change ∙ Feature Preview
Add a default title for donations that are not streams:
const title = !isDonation
? (isUBIPool ? 'Recipient claim' : 'Recipient Payout')
: (isStream || 'Donation');Provide feedback to improve future suggestions
💬 Looking for more details? Reply to this comment to chat with Korbit.
| titleStyle={styles.desktopTitleUnderline} | ||
| stewards={collective?.stewardCollectives} | ||
| listType="viewStewards" | ||
| listStyle={{ height: '60vh' }} |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
L03TJ3
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As required by #275 this PR:
How Has This Been Tested?
Running the application and checking all the pages to make sure they work, that steward is replaced by recipient, that the list of steward fits vertically in the screen in the collective view and in the view of stewards and that it is ordered by actions as the following screenshot and video show:
collective-stewards-issues-275.webm
I would appreciate review of @L03TJ3
Checklist:
Description by Korbit AI
What change is being made?
Update the terminology in the UI from "Stewards" to "Recipients" across multiple components and enhance the StewardList component by ordering the stewards based on their actions in descending order.
Why are these changes being made?
These changes address UI issues by ensuring consistent terminology in the application, thereby improving user understanding and interface consistency. The ordering of the stewards is implemented to present the list more intuitively by actions, enhancing user experience in navigating through the list. This aligns with stakeholder feedback and resolves issue #275.