adding pooltype label to banner

[ManyRios]

Description

Added pooltypes label to the banner

About # (link your issue here)
#279

Checklist:

• I have performed a self-review of my own code
• My changes generate no new warnings

Description by Korbit AI

What change is being made?

Add a "poolType" label to the Banner component by introducing a new BannerPool component and integrating it into various sections of the code, such as CollectiveHomeCard and ViewCollective.

Why are these changes being made?

These changes are implemented to visually represent the pool type associated with different banners, improving user awareness and enriching the UI experience. The BannerPool provides a cohesive way to handle and display different pool types using images, enhancing clarity in application design.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[sourcery-ai]

Hey @ManyRios - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using a more descriptive name than pooltype for the prop, such as poolTypeIdentifier.
• The getPoolType function could be refactored into a component that returns the image directly.

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[korbit-ai]

I've completed my review and didn't find any issues... but I did find this beaver.

     .-"""-.__
    /      ' o'\
 ,-;  '.  :   _c
:_."\._ ) ::-"
       ""m "m

Files scanned

​

File Path	Reviewed
packages/app/src/custom.d.ts	✅
packages/app/src/assets/index.ts	✅
packages/app/src/components/ViewCollective.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[ManyRios]

@L03TJ3

[sirpy]

@ManyRios @L03TJ3
Shouldn't the label be applied also in lists of pools not just on the pool page?

@ManyRios please fix the AI review comments

1. use style without px
2. hex color should be ffffff
3. image header can be extracted to a component not to repeat

[L03TJ3]

@ManyRios

1. use .png as format.
2. Yes on @sirpy s comment. this label should also be applied/visible on the cards shown in the pools list on the mainpage (goodcollective.xyz)

[sirpy]

@ManyRios

1. use .png as format.
2. Yes on @sirpy s comment. this label should also be applied/visible on the cards shown in the pools list on the mainpage (goodcollective.xyz)

@ManyRios
There could be other lists, it should simply be a component displayed anywhere the group image is displayed

[ManyRios]

@ManyRios @L03TJ3 Shouldn't the label be applied also in lists of pools not just on the pool page?

Oh my bad...

[ManyRios]

hey @L03TJ3 what is your discord?

[L03TJ3]

@ManyRios You can find our gooddollar discord here: https://discord.gg/wr34jErY
That will bring you into the builders chat.
If you want more direct support you can request a 'scouts' label there!

[ManyRios]

@ManyRios You can find our gooddollar discord here: https://discord.gg/wr34jErY
That will bring you into the builders chat.
If you want more direct support you can request a 'scouts' label there!

Yes. Im already in the server. Please review this changes when you're ready

[L03TJ3]

@ManyRios Sorry for the delay.

1. the click event on the cards fires weird. if you click on the banner, it first does opens the pool and then redirects. this should be fixed
2. on the homepage cards, the image can be slightly smaller.

[ManyRios]

@ManyRios Sorry for the delay.

1. the click event on the cards fires weird. if you click on the banner, it first does opens the pool and then redirects. this should be fixed
2. on the homepage cards, the image can be slightly smaller.

Sorry I forgot the "TouchableOpacity" component. Done @sirpy @L03TJ3

[L03TJ3]

@ManyRios Thanks for the changes!

[ManyRios]

@ManyRios Thanks for the changes!

Hi! How I can claim the reward?