New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Package.swift #1

Open

milch wants to merge 1 commit into GoodNotes:goodnotes-master from milch:swift-package-manager

milch commented Feb 1, 2021

Hey there,

Not sure if your fork will accept PRs, but wanted to submit it anyway since it seems to be more recently maintained compared to upstream.

This PR adds SPM support. SPM unfortunately is very peculiar about where files need to be placed:

It does not support RocksDB's style of placing test files next to source files very well, hence the long list of source files and excludes
You can only define a single folder for public headers, which is why I had to move those into a separate include dir
I found no way to generate files during the build with SPM, so there's some logic there to replace the generated file with defines during the build


          Add Package.swift

66cc127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet