Add TWA high priority notifications test site - #608
Open
Dp-Goog wants to merge 5 commits into
Open
Conversation
Dp-Goog
force-pushed
the
twa-notification-high-priority
branch
from
August 7, 2026 17:14
be621bf to
dfb1179
Compare
Dp-Goog
force-pushed
the
twa-notification-high-priority
branch
from
August 7, 2026 17:54
dfb1179 to
f433fc3
Compare
PEConn
reviewed
Aug 10, 2026
| } | ||
|
|
||
| @Override | ||
| public boolean onNotifyNotificationWithChannel( |
Contributor
There was a problem hiding this comment.
What's the purpose of this functionality?
Author
There was a problem hiding this comment.
This is mostly a copy of the TWA notification delegation demo that plays an air-horn, with some debug information added, like onCreate() and onDestroy() to know when the service has been created or destroyed, and the logs on L57-60 to track the channel name and importance.
Contributor
There was a problem hiding this comment.
I think it may be a distraction. I'd expect people to come to this demo looking at how to implement high priority notifications and blindly copy-pasting stuff. In that case do we want them modifying the notifications?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a sample test TWA that wraps https://dp-goog.github.io/notifications-api-testing/, so that SW notifications can be sent. This mostly mimics the code in
twa-notification-delegation, with the old code changes being:androidx.browser.trusted.USE_HIGH_PRI_NOTIFICATIONSfield set.https://dp-goog.github.io/notifications-api-testing/instead.Verified that it works, based on the following logs: