Open
Conversation
DanielRyanSmith
approved these changes
Mar 3, 2026
DanielRyanSmith
requested changes
Mar 3, 2026
Collaborator
DanielRyanSmith
left a comment
DanielRyanSmith
left a comment
There was a problem hiding this comment.
Actually , we might want to take screenshots that test states where the mouse hovers over an element. Maybe we can add the mouse movement adjustment as needed, separate from the screenshot function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try a longer timeout when checking screenshots because sometimes icons and CSS takes longer than 5s to load.
The longer timeout does not seem to increase the total run time by much. Maybe from 6m to 7m. It seems to reduce the number of flakey failures, but not eliminate them. Also, having a screenshot helper function is a starting point to eventually having tests that support dark mode.