Modernize "Getting Started" Guide#1124
Open
terrabitz wants to merge 10 commits intoGoogleChrome:mainfrom
Open
Conversation
Signed-off-by: Trevor Taubitz <trevor.taubitz@flocksafety.com>
Signed-off-by: Trevor Taubitz <trevor.taubitz@flocksafety.com>
Signed-off-by: Trevor Taubitz <trevor.taubitz@flocksafety.com>
Signed-off-by: Trevor Taubitz <trevor.taubitz@flocksafety.com>
nickspaargaren
suggested changes
Feb 5, 2026
nickspaargaren
left a comment
There was a problem hiding this comment.
Node 18 has reached end of life and has been unsupported since April 2025. Let’s use Node 24 LTS.
Let's see if the CI passes 😉
|
Don't forget to update the node versions in the Dockerfiles as well; |
Signed-off-by: Trevor Taubitz <trevor.taubitz@flocksafety.com>
Signed-off-by: Trevor Taubitz <trevor.taubitz@flocksafety.com>
Signed-off-by: Trevor Taubitz <trevor.taubitz@flocksafety.com>
Signed-off-by: Trevor Taubitz <trevor.taubitz@flocksafety.com>
nickspaargaren
approved these changes
Feb 5, 2026
Signed-off-by: Trevor Taubitz <trevor.taubitz@flocksafety.com>
|
Again, let's see if the CI passes 😉 |
Signed-off-by: Trevor Taubitz <trevor.taubitz@flocksafety.com>
Author
|
@nickspaargaren even better! 🎉
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a number of updates to modernize the recommendations:
statusesoption.actions/*actions to their latest versions. This is done on the README, the "Getting Started" page, and the actual GHA workflows.lhcihas any issues with this version, I'm hoping they'll be surfaced through the CI checksI did a basic test of these changes through a minimal PoC, which you can find here: terrabitz/lighthouse-ci-poc#1. In the PR, you can see that a status check was successfully created:
Implementation notes
For the example code, I used a diff block since I personally like to see the highlighted changes when it comes to a smaller modification on a larger block. Downside is it makes it less copy-pastable. I'm open to suggestions
Although the GitHub actions updates are technically semver breaking changes, they should be backwards-compatible; the only major difference is what Node engine version is used to precompile them. I personally have never had an issue during these upgrades.
I opted to do all these changes together for ease, but please let me know if you want these changes broken up. I'd be happy to split them if that lowers the blast radius.
This PR should cover Use latest GitHub Action for checkout #1111
I have updated Node references in each CI provider's "Getting Started" section, but the only one I've personally tested is GHA. I don't have a good setup to test each of the other providers. I'm hoping because it's just image updates, it shouldn't break anything.