Add github action for testing #65
Conversation
Just checking to see how far this gets currently or if we need to disable webgpu tests.
brendandahl
changed the title
brendandahl
changed the title
| runs-on: macos-latest | ||
| strategy: | ||
| matrix: | ||
| # TODO enable safari and firefox |
There was a problem hiding this comment.
side comment: I've seen that there are some resource limitations with macos so I've split the tasks in JetStream to be able to run on linux (though these are slightly slower machines).
https://github.com/WebKit/JetStream/blob/main/.github/workflows/test.yml
| }); | ||
| assert(metrics.Geomean.values.length === 1); | ||
| assert(metrics.Score.values.length === 1); | ||
| } |
There was a problem hiding this comment.
nit (I unfortunately cannot add a comment to line 6, since it's too far away from the diff): Can you replace Speedometer with benchmark (both in the help text and ideally also the SpeedometerDone event)?
| async function test() { | ||
| try { | ||
| await driver.manage().setTimeouts({ script: 60000 }); | ||
| await driver.manage().setTimeouts({ script: 20 * 60000 }); |
There was a problem hiding this comment.
very small nit: Could you make 60000 a const ONE_MINUTE_IN_MS = 60000 or so, to make this a somewhat less magic number?
Also, at a high-level: 20 minutes is a really long time out, do we have a lighter workload?
4 participants
The full e2e tests are very slow, but they pass with an increased timeout.
Enabled for chrome only for now.
Fixes #60