Skip to content

Support passing command line flags to start the browser.#74

Merged
brendandahl merged 1 commit into
GoogleChrome:mainfrom
brendandahl:add-browser-args
Feb 5, 2026
Merged

Support passing command line flags to start the browser.#74
brendandahl merged 1 commit into
GoogleChrome:mainfrom
brendandahl:add-browser-args

Conversation

@brendandahl

@brendandahl brendandahl commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

e.g. --browser-arg="--enable-unsafe-webgpu" --browser-arg="--js-flags=\"--experimental-wasm-fp16\""

e.g. `--browser-arg="--enable-unsafe-webgpu" --browser-arg="--js-flags=\"--experimental-wasm-fp16\""
@brendandahl brendandahl requested a review from rmahdav January 28, 2026 23:05
@brendandahl

Copy link
Copy Markdown
Collaborator Author

FWIW, I wanted to make it so you can put them all in one flag, but there's some weirdness happening with how webdriver args works and using the --js-flags. I could probably fix it, but then we'd need to parse the arguments, which seems like overkill.

@rmahdav rmahdav left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: These browser args are passed when the tests in CI are running? Or they also can be passed if someone trying to run the benchmark locally? I am trying to figure out if we need to edit README file as well or not.

@brendandahl

Copy link
Copy Markdown
Collaborator Author

They currently just work with running the test scripts directly. This is what I'm using to run on my cloudtop: node tests/run-end2end.mjs --browser chrome --browser-arg="--enable-unsafe-webgpu".

@rmahdav rmahdav left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

@brendandahl brendandahl merged commit 7ca8fad into GoogleChrome:main Feb 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants