Create a new generated npm workspace for typescript ANTLR generated code #1371
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,20 @@ | ||||||||||
| { | ||||||||||
| "name": "@webstatus.dev/ts-antlrv4", | ||||||||||
| "version": "1.0.0", | ||||||||||
| "description": "TypeScript ANTLR4 generated code for webstatus.dev", | ||||||||||
| "main": "dist/index.js", | ||||||||||
| "types": "dist/index.d.ts", | ||||||||||
| "license": "Apache-2.0", | ||||||||||
| "scripts": { | ||||||||||
| "build": "tsc", | ||||||||||
| "clean": "rimraf dist" | ||||||||||
|
Comment on lines
+9
to
+10
There was a problem hiding this comment.
Suggested change
We should rely on the system rm command. |
||||||||||
| }, | ||||||||||
| "dependencies": { | ||||||||||
| "antlr4": "^4.13.1" | ||||||||||
| }, | ||||||||||
| "devDependencies": { | ||||||||||
| "@types/antlr4": "^4.9.3", | ||||||||||
| "typescript": "^5.0.0", | ||||||||||
| "rimraf": "^5.0.0" | ||||||||||
|
Comment on lines
+17
to
+18
There was a problem hiding this comment. Can remove this
Suggested change
|
||||||||||
| } | ||||||||||
| } | ||||||||||
|
There was a problem hiding this comment. Ideally, we should have a common tsconfig that both the frontend and this package extend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "target": "ES2020", | ||
| "module": "ES2020", | ||
| "moduleResolution": "node", | ||
| "declaration": true, | ||
| "outDir": "./dist", | ||
| "strict": true, | ||
| "esModuleInterop": true, | ||
| "skipLibCheck": true, | ||
| "forceConsistentCasingInFileNames": true | ||
| }, | ||
| "include": [ | ||
| "antlr/**/*.ts" | ||
| ], | ||
| "exclude": [ | ||
| "node_modules", | ||
| "dist" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a new target like:
build-antlr-tsIt should call the npm run build command in the
lib/gen/antlrv4/ts-antlrv4directory.We currently have one shot commands such as make start-local and make debug-local and make precommit and make playwright-test. It will be necessary to add this target as a pre-requisite target for those.
https://github.com/GoogleChrome/webstatus.dev/blob/401f3e814e1ce0d6eebbd73d77c2bafd3a3c3f1f/DEVELOPMENT.md
https://github.com/GoogleChrome/webstatus.dev/blob/401f3e814e1ce0d6eebbd73d77c2bafd3a3c3f1f/docs/testing.md